Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: patch for assets controller v11.0.1 #8881

Merged
merged 10 commits into from
Mar 14, 2024
Merged

feat: patch for assets controller v11.0.1 #8881

merged 10 commits into from
Mar 14, 2024

Conversation

tommasini
Copy link
Contributor

@tommasini tommasini commented Mar 7, 2024 •
edited
Loading

Description

Update to assets controller version 11.0.1

  • This version mainly had changes on TokenRatesController that we already had on our repo

Check more easily the diff on this core branch: patch/mobile-assets-controllers-v-11-0-1

This PR removes a unnecessary resolution since, the package babel-runtime was removed from assets-controllers on version 11.0.0

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Import tokens: https://recordit.co/fLGuFr20AH
import NFts: https://recordit.co/GlDRhQoIfp

Optimism send transaction and import tokens: https://recordit.co/RHtJ7y0jxB

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security Socket Security
Copy link

socket-security bot commented Mar 7, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/assets-controllers@11.0.1 Transitive: environment, filesystem, network +142 33.3 MB metamaskbot

🚮 Removed packages: npm/@metamask/assets-controllers@10.0.0

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Mar 7, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.27%. Comparing base (ef5febd) to head (28e2bc6).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8881   +/-   ##
=======================================
  Coverage   43.27%   43.27%           
=======================================
  Files        1271     1271           
  Lines       30916    30916           
  Branches     3092     3092           
=======================================
  Hits        13378    13378           
  Misses      16765    16765           
  Partials      773      773

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tommasini tommasini added the Run Smoke E2E Triggers smoke e2e on Bitrise label Mar 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dcfc308
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/464fdb3c-0523-468c-94aa-5eb986c5f877

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

tommasini and others added 3 commits March 12, 2024 15:50
@tommasini tommasini marked this pull request as ready for review March 13, 2024 14:11
@tommasini tommasini requested a review from a team as a code owner March 13, 2024 14:11
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 28e2bc6
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/db6b81ad-30c3-44ef-9930-c03d20188aaf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@leotm leotm self-requested a review March 13, 2024 19:28
@metamaskbot metamaskbot added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) and removed in-progress labels Mar 14, 2024
@leotm leotm changed the title feat: patch for assets controller v11 feat: patch for assets controller v11.0.1 Mar 14, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

leotm
leotm approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@leotm leotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx @tommasini for reviewing this with me and updating the script

lgtm after running the script in this branch and noting no changes

and also after checking https://github.com/MetaMask/core/tree/patch/mobile-assets-controllers-v-11-0-1 and running yarn build and checking dist folders

@tommasini tommasini merged commit c94a586 into main Mar 14, 2024
30 of 31 checks passed
@tommasini tommasini deleted the feat/1554-update-assets-controllers-v11-0-1 branch March 14, 2024 13:33
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
@metamaskbot metamaskbot added the release-7.19.0 Issue or pull request that will be included in release 7.19.0 label Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leotm leotm leotm approved these changes

Assignees
No one assigned
Labels
release-7.19.0 Issue or pull request that will be included in release 7.19.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tommasini @codecov-commenter @leotm @metamaskbot